This repository was archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
This repository was archived by the owner on Feb 12, 2024. It is now read-only.
ipfs add zero filled uint8 fails against go #3542
Copy link
Copy link
Closed
Labels
P2Medium: Good to have, but can wait until someone steps upMedium: Good to have, but can wait until someone steps upeffort/daysEstimated to take multiple days, but less than a weekEstimated to take multiple days, but less than a weekenv:Firefoxexp/intermediatePrior experience is likely helpfulPrior experience is likely helpfulkind/bugA bug in existing code (including security flaws)A bug in existing code (including security flaws)kind/maybe-in-helianeed/maintainer-inputNeeds input from the current maintainer(s)Needs input from the current maintainer(s)status/readyReady to be workedReady to be worked
Description
This test https://github.com/ipfs/js-ipfs/blob/master/packages/interface-ipfs-core/src/add.js#L84 fails running the interface tests against go-ipfs in firefox ONLY.
This is the data used in the test https://github.com/ipfs/js-ipfs/blob/master/packages/interface-ipfs-core/src/utils/index.js#L26, changing the input to something like https://github.com/ipfs/js-ipfs/blob/master/packages/interface-ipfs-core/test/fixtures/test-folder/holmes.txt makes the test pass.
dag from go-ipfs
In this PR #3528 i changed the input data to make the test pass because it looks like this only happens with 0 filled buffers, but this needs a real fix.
Metadata
Metadata
Assignees
Labels
P2Medium: Good to have, but can wait until someone steps upMedium: Good to have, but can wait until someone steps upeffort/daysEstimated to take multiple days, but less than a weekEstimated to take multiple days, but less than a weekenv:Firefoxexp/intermediatePrior experience is likely helpfulPrior experience is likely helpfulkind/bugA bug in existing code (including security flaws)A bug in existing code (including security flaws)kind/maybe-in-helianeed/maintainer-inputNeeds input from the current maintainer(s)Needs input from the current maintainer(s)status/readyReady to be workedReady to be worked