Tell browserify to fix up fs.readFileSync calls #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@substack suggested that this would make browserify able to actually package this module. Without running through brfs, it packages up just fine, but browserify provides an empty `fs` implementation, so when this module goes to load the .proto files on startup it fails.
|
Looks like the network "before all" hook test is timing out. I suspect it's not my fault. |
|
Thank you but not needed anymore with #41 |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@substack suggested that this would make browserify able to actually package this module. Without running through brfs, it packages up just fine, but browserify provides an empty
fsimplementation, so when this module goes to load the .proto files on startup it fails.