Offset Geometric Contact #192
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n Candidates class
- Introduced CollisionSetType enum to manage different collision strategies: IPC, IMPROVED_MAX_APPROX, and OGC. - Updated NormalCollisions and NormalCollisionsBuilder to utilize the new collision set type. - Replaced deprecated methods related to improved max approximator with the new collision set type methods. - Enhanced collision building logic to accommodate the new OGC strategy. - Updated tests to validate behavior across different collision set types.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
==========================================
- Coverage 95.98% 95.90% -0.09%
==========================================
Files 104 108 +4
Lines 8077 8407 +330
==========================================
+ Hits 7753 8063 +310
- Misses 324 344 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 39 out of 42 changed files in this pull request and generated 6 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…ions in collision_mesh.cpp; remove unused assertions in normal_collisions_builder.cpp and clean up test_barrier_potential.cpp
…rtions in OGC tests
…and implement unit tests for TrustRegion functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of "Offset Geometric Contact" [Chen et al. 2025].
Details
TODO: list of detailed changes
Type of change