Skip to content

VC Data Model v2.0 #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

VC Data Model v2.0 #1738

wants to merge 14 commits into from

Conversation

@UMR1352
Copy link
Contributor

@UMR1352 UMR1352 commented Nov 3, 2025

Description of change

Integrate VC Data Model 2.0 within identity_credential.

Links to any relevant issues

Closes #1275

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

@UMR1352 UMR1352 requested a review from wulfraem November 3, 2025 14:59
@UMR1352 UMR1352 self-assigned this Nov 3, 2025
@UMR1352 UMR1352 added Enhancement New feature or improvement to an existing feature Added A new feature that requires a minor release. Part of "Added" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Nov 3, 2025
@UMR1352 UMR1352 added the Wasm Related to Wasm bindings. Becomes part of the Wasm changelog label Nov 6, 2025
@UMR1352 UMR1352 marked this pull request as ready for review November 6, 2025 13:52
wulfraem
wulfraem requested changes Nov 10, 2025
View reviewed changes
@UMR1352 UMR1352 requested a review from wulfraem November 18, 2025 09:29
wulfraem
wulfraem requested changes Nov 18, 2025
View reviewed changes
Copy link
Contributor

@wulfraem wulfraem left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you do a manual merge with main again?

This should help to get the CI back to green, as the CI is not testing the PR branch tip, but the resulting merge that has the duplicate Default derives for StatusCheck and SubjectHolderRelationship and after the manual merge they should be fixable. ^^

@UMR1352
Copy link
Contributor Author

UMR1352 commented Nov 19, 2025

Could you do a manual merge with main again?

This should help to get the CI back to green, as the CI is not testing the PR branch tip, but the resulting merge that has the duplicate Default derives for StatusCheck and SubjectHolderRelationship and after the manual merge they should be fixable. ^^

Thanks dude, I was going crazy trying to figure out why this was happening 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wulfraem wulfraem wulfraem requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@UMR1352 UMR1352

Labels

Added A new feature that requires a minor release. Part of "Added" section in changelog Enhancement New feature or improvement to an existing feature Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Task] Add support for VC Data Model 2.0

3 participants

@UMR1352 @wulfraem