Version from pip package & CI #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: artivis <[email protected]>
Signed-off-by: artivis <[email protected]>
iosifache
requested changes
Jan 12, 2024
There was a problem hiding this comment.
The action will build the snap only for the architecture of the GitHub runner.
Shouldn't the action run for each architecture on which the snap should run (for example, by using matrix)? In this case, the snaps for all architectures will be uploaded by calling the publish step multiple times.
The rest looks good!
|
Unfortunately there aren't arm-based runners as of now. |
|
Just discovered this, but did you play in the past with |
|
I haven't used this action, other similar exists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the snap version from the pip package and add a snap CI workflow.
To automatically publish the snap to the store you will need to set up the credential in
SNAPCRAFT_STORE_CREDENTIALS, see the action doc.