-
Notifications
You must be signed in to change notification settings - Fork 13.5k
test(angular): add ng20 test app #30507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -8,7 +8,7 @@ runs: | |||
steps: | |||
- uses: actions/setup-node@v4 | |||
with: | |||
node-version: 18 | |||
node-version: 22.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Angular 20 requires a minimal node version of 20. I verified that version 22 works with all the Angular test apps that we support. By updating it to 22.x
, renovate will be able to update it when necessary instead of keeping it pinned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Issue number: internal
What is the current behavior?
There are tests apps for Angular 16, 17, 18, and 19 only. Angular 20 has been released and should be included.
What is the new behavior?
Does this introduce a breaking change?
Other information
N/A