Skip to content

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Nov 9, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

During testing, I noticed that my implemented of the notch in the MD outline was incorrect, causing the gap to be much wider than necessary when using longer labels.

I also noticed that long label texts do not flow correctly in the container.

What is the new behavior?

  • Long labels are now correctly truncated so they do not break the input layout
  • Revamped how we create the notch in the MD outline style so the gap is correctly sized.
  • Added tests

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Nov 9, 2022
@liamdebeasi liamdebeasi changed the title fix(input): begin fixing notch adjustment fix(input): floating label works correctly with long text and notch Nov 9, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review November 9, 2022 19:57
@liamdebeasi liamdebeasi requested a review from a team as a code owner November 9, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants