Skip to content

feat(input): add form highlighting #26231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 148 commits into from
Nov 11, 2022
Merged

feat(input): add form highlighting #26231

merged 148 commits into from
Nov 11, 2022

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Nov 4, 2022 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Inputs using the new form syntax do not have form validity highlighting.

What is the new behavior?

  • Valid + Touched inputs will now have a green/success highlight
  • Invalid + Touched input will now have a red/danger highlight
  • On MD only inputs will have the default (primary color) highlight when focused. Validity states will override this color.

Note: This PR does not add support for the color property. This will be handled in a separate PR.

Does this introduce a breaking change?

  • Yes
  • No

Other information

liamdebeasi and others added 30 commits October 31, 2022 15:38
@liamdebeasi
feat(input): add new js and css props
621dc13
@liamdebeasi
chore(): copy updates
d24428c
@liamdebeasi
test(input): move old tests to legacy directory
0402ae8
@liamdebeasi
feat(input): add legacy vs modern template rendering
7643d2d
@liamdebeasi
refactor(form): add form controller
259a3a2
@liamdebeasi
chore(): update comments
a989e94
@liamdebeasi
chore(): update tests
2a80a5f
@liamdebeasi
chore(): add moved screenshots
08ea3a0
@liamdebeasi
chore(): add moved screenshots
bd80054
@liamdebeasi
chore(): fix test file
19f4994
@liamdebeasi
chore(): prettier
d02c144
@liamdebeasi
feat(input): add base functionality and tests
cea5615
@liamdebeasi
feat(input): add missing fixed label
8d7f0c4
@liamdebeasi
feat(input): add basic help text rendering
6eabc11
@liamdebeasi
feat(input): add helper and error text
0259004
@liamdebeasi
chore(): update descriptions for clarity
5f765a0
@liamdebeasi
test(input): make sure correct content is rendered
3e4f70c
@liamdebeasi
test(input): make sure error color can be customized
232d868
@liamdebeasi
chore(): update test
2f6019b
@Ionitron
chore(): add updated snapshots
5c3bb0c
@liamdebeasi
refactor(item): deprecate helper and error slots
f8dc97f
@liamdebeasi
Merge branch '2591-helper' of https://github.com/ionic-team/ionic-fra…
23af9da 
…mework into 2591-helper
@liamdebeasi
feat(input): add counter support
eeb7124
@liamdebeasi
refactor(item): deprecate counter and counterFormatter
b9da66c
@liamdebeasi
chore(): a few tweaks
516a615
@liamdebeasi
test(input): clean up tests
2d07367
@liamdebeasi
Merge remote-tracking branch 'origin/2591-helper' into 2591-counter
4a4aca7
@liamdebeasi
test(input): add counter tests
f855134
@liamdebeasi
chore(): update prop description
a7e4426
@liamdebeasi
Merge remote-tracking branch 'origin/FW-2591' into 2591-props
fff8ed1
@github-actions github-actions bot added the package: core @ionic/core package label Nov 4, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review November 4, 2022 19:58
@liamdebeasi liamdebeasi requested a review from a team as a code owner November 4, 2022 19:58
@averyjohnston
Copy link
Contributor

Looks like some extra screenshots from the fill test snuck in here?

@liamdebeasi
Copy link
Contributor Author

I think that was related to a merge conflict. Should be good to go now.

averyjohnston
averyjohnston reviewed Nov 8, 2022
View reviewed changes
Base automatically changed from 2591-fill to FW-2591 November 11, 2022 17:13
@liamdebeasi liamdebeasi merged commit 203c55e into FW-2591 Nov 11, 2022
@liamdebeasi liamdebeasi deleted the 2591-highlight branch November 11, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@sean-perkins sean-perkins sean-perkins approved these changes

@averyjohnston averyjohnston averyjohnston approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liamdebeasi @averyjohnston @sean-perkins @Ionitron