Skip to content

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: N/A

Disabled state did not render correctly with new input syntax. The input was dimmed but not the label.

What is the new behavior?

  • The entire component is now dimmed when the component is disabled
  • Added disabled screenshot test
  • Added readonly screenshot test

Does this introduce a breaking change?

  • Yes
  • No

Other information

liamdebeasi and others added 30 commits October 31, 2022 15:38
@github-actions github-actions bot added the package: core @ionic/core package label Nov 3, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review November 3, 2022 21:09
@liamdebeasi liamdebeasi requested a review from a team as a code owner November 3, 2022 21:09
Base automatically changed from 2591-placement to FW-2591 November 8, 2022 16:00
@liamdebeasi liamdebeasi merged commit e03b1fb into FW-2591 Nov 8, 2022
@liamdebeasi liamdebeasi deleted the 2591-disabled-readonly branch November 8, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants