-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(input): add labelPlacement #26206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
621dc13
feat(input): add new js and css props
liamdebeasi d24428c
chore(): copy updates
liamdebeasi 0402ae8
test(input): move old tests to legacy directory
liamdebeasi 7643d2d
feat(input): add legacy vs modern template rendering
liamdebeasi 259a3a2
refactor(form): add form controller
liamdebeasi a989e94
chore(): update comments
liamdebeasi 2a80a5f
chore(): update tests
liamdebeasi 08ea3a0
chore(): add moved screenshots
liamdebeasi bd80054
chore(): add moved screenshots
liamdebeasi 19f4994
chore(): fix test file
liamdebeasi d02c144
chore(): prettier
liamdebeasi cea5615
feat(input): add base functionality and tests
liamdebeasi 8d7f0c4
feat(input): add missing fixed label
liamdebeasi 6eabc11
feat(input): add basic help text rendering
liamdebeasi 0259004
feat(input): add helper and error text
liamdebeasi 5f765a0
chore(): update descriptions for clarity
liamdebeasi 3e4f70c
test(input): make sure correct content is rendered
liamdebeasi 232d868
test(input): make sure error color can be customized
liamdebeasi 2f6019b
chore(): update test
liamdebeasi 5c3bb0c
chore(): add updated snapshots
Ionitron f8dc97f
refactor(item): deprecate helper and error slots
liamdebeasi 23af9da
Merge branch '2591-helper' of https://github.com/ionic-team/ionic-fra…
liamdebeasi eeb7124
feat(input): add counter support
liamdebeasi b9da66c
refactor(item): deprecate counter and counterFormatter
liamdebeasi 516a615
chore(): a few tweaks
liamdebeasi 2d07367
test(input): clean up tests
liamdebeasi 4a4aca7
Merge remote-tracking branch 'origin/2591-helper' into 2591-counter
liamdebeasi f855134
test(input): add counter tests
liamdebeasi a7e4426
chore(): update prop description
liamdebeasi fff8ed1
Merge remote-tracking branch 'origin/FW-2591' into 2591-props
liamdebeasi 563f177
Update core/src/components/input/input.tsx
liamdebeasi e1696af
chore(): run build
liamdebeasi a17a9ae
Merge remote-tracking branch 'origin/2591-props' into 2591-template
liamdebeasi b458fe7
Merge remote-tracking branch 'origin/2591-template' into 2591-base
liamdebeasi eace2ec
Merge branch '2591-base' into 2591-helper
liamdebeasi 8be3a58
Merge remote-tracking branch 'origin/2591-helper' into 2591-counter
liamdebeasi f556aee
chore(input): remove justify property
liamdebeasi f65f289
chore(): add updated snapshots
Ionitron e93d734
feat(input): add wip placement
liamdebeasi 71cec98
chore(): clean up styles
liamdebeasi 3a2e063
test(input): add label placement to a11y test
liamdebeasi d3d10db
test(input): add label placement template
liamdebeasi 9ac44c1
fix(input): adjust input sizing for platform specs
liamdebeasi b2f5879
test(input): add tests for label placement
liamdebeasi 55092f1
Merge remote-tracking branch 'origin/2591-counter' into 2591-placement
liamdebeasi 661be60
chore(): add updated snapshots
Ionitron 6b8131a
Update core/src/components/input/input.tsx
liamdebeasi e0b5cd6
feat(input): add missing fill property
liamdebeasi 5a0f812
refactor(): explicitly add element type
liamdebeasi 2bf7b10
test(input): mask test uses new syntax
liamdebeasi 1cc337a
refactor(input): access props once
liamdebeasi 9f04dd1
Merge branch '2591-base' into 2591-helper
liamdebeasi 4272366
chore(): fix el type
liamdebeasi 6d09ad6
Merge remote-tracking branch 'origin/2591-props' into 2591-template
liamdebeasi 9632c22
Merge remote-tracking branch 'origin/2591-template' into 2591-base
liamdebeasi 79ff704
Merge remote-tracking branch 'origin/2591-base' into 2591-helper
liamdebeasi aa7edae
Merge remote-tracking branch 'origin/2591-helper' into 2591-counter
liamdebeasi 15b1ab6
chore(): sync
liamdebeasi 7670a27
chore(): padding is set on wrapper
liamdebeasi 0a66283
chore(): use mixin
liamdebeasi 3408223
fix(input): padding applied to input wrapper
liamdebeasi 10d2af3
fix(input): fixed label does not have end margin
liamdebeasi 0dceaf6
chore(): add updated snapshots
Ionitron 49c7563
refactor(input): move label class to host
liamdebeasi a85ca3b
Revert "chore(): add updated snapshots"
liamdebeasi e58033b
fix(input): adjust size and label offset
liamdebeasi 04e17bb
chore(): add updated snapshots
Ionitron 6323b0c
chore(): sync
liamdebeasi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,8 @@ <h1>Input - a11y</h1> | |
|
||
<ion-input label="my label"></ion-input> | ||
<ion-input aria-label="my aria label"></ion-input> | ||
<ion-input label="Email" label-placement="stacked" value="[email protected]"></ion-input> | ||
<ion-input label="Email" label-placement="floating"></ion-input> | ||
</main> | ||
</body> | ||
</html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.