Skip to content

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Oct 31, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: N/A internal ticket

This is one PR of several for the FW-2591 feature

What is the new behavior?

  • Adds a <label>, <input>, and the clear button elements inside of the new input render function
  • Added tests for the modern layout that tests functionality. I only added tests that are already being used for the legacy layout. Tests for the new properties will be in a future PR. The goal of this PR is to ensure existing functionality is preserved before layering on new functionality.

Note: No styles have been updated which is why screenshot tests are skipped for now. These will be re-enabled in a future PR.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Oct 31, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review October 31, 2022 19:22
@liamdebeasi liamdebeasi requested a review from a team as a code owner October 31, 2022 19:22
Base automatically changed from 2591-template to FW-2591 November 7, 2022 18:00
@liamdebeasi liamdebeasi merged commit 14b7bd4 into FW-2591 Nov 7, 2022
@liamdebeasi liamdebeasi deleted the 2591-base branch November 7, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants