-
Notifications
You must be signed in to change notification settings - Fork 3.2k
docs(v6): Update v6 StackBlitz set up and examples for JavaScript and Angular #4213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs(v6): Update v6 StackBlitz set up and examples for JavaScript and Angular #4213
Conversation
@soundproofboot is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This should also resolve #3728 ![]() Screenshot from v6 Angular Filled Inputs StackBlitz on this branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor requests
redirectTo: 'example', | ||
pathMatch: 'full', | ||
}, | ||
]; No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We add new lines at the end of the files as a standard.
]; | |
]; | |
importProvidersFrom(IonicModule.forRoot({ })), | ||
provideRouter(routes, withPreloading(PreloadAllModules)), | ||
], | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We add new lines at the end of the files as a standard.
}) | |
}) | |
resolves #4199
Changes
static/code/stackblitz/v6/html
to allow JavaScript examples to load correctly in StackBlitz.static/code/stackblitz/v6/angular
to allow Angular examples to load correctly in StackBlitz.IonicModule
andstandalone: true
to all Angular examples that need anexample.component.ts
file.addIcons
method in component constructor, creating the component files if they did not exist.version
to string inglobal/Playground
files to match how version is passed in Playgrounds component. I believe it was incorrectly typed but not used in a way that would throw an error. This was necessary to allow a branch for v6 only inloadSourceFiles
where themode
is inserted inmain.ts
.addIcons
method in a new.ts
file.Additional Information
versions.json
and remove the "v6" entry inversionsArchived.json
. This is not in the PR because v6 should not be in the build but will need to be rebuilt and redeployed to Vercel, and the link to the new build updated inversionsArchived.json
.https://developer.school
has two colons but also seems to no longer exist).