Skip to content

docs(modal): update controller example for react #3535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2024
Merged

docs(modal): update controller example for react #3535

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16f75d6
docs(modal): update controller example for react
mhartington Mar 19, 2024
413919c
chore: lint
liamdebeasi Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions static/usage/v8/modal/controller/react.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,24 +14,20 @@ import {
} from '@ionic/react';
import { OverlayEventDetail } from '@ionic/core/components';

const ModalExample = ({
onDismiss,
}: {
onDismiss: (data?: string | null | undefined | number, role?: string) => void;
}) => {
const ModalExample = ({ dismiss }: { dismiss: (data?: string | null | undefined | number, role?: string) => void }) => {
const inputRef = useRef<HTMLIonInputElement>(null);
return (
<IonPage>
<IonHeader>
<IonToolbar>
<IonButtons slot="start">
<IonButton color="medium" onClick={() => onDismiss(null, 'cancel')}>
<IonButton color="medium" onClick={() => dismiss(null, 'cancel')}>
Cancel
</IonButton>
</IonButtons>
<IonTitle>Welcome</IonTitle>
<IonButtons slot="end">
<IonButton onClick={() => onDismiss(inputRef.current?.value, 'confirm')} strong={true}>
<IonButton onClick={() => dismiss(inputRef.current?.value, 'confirm')} strong={true}>
Confirm
</IonButton>
</IonButtons>
Expand All @@ -48,7 +44,7 @@ const ModalExample = ({

function Example() {
const [present, dismiss] = useIonModal(ModalExample, {
onDismiss: (data: string, role: string) => dismiss(data, role),
dismiss: (data: string, role: string) => dismiss(data, role),
});
const [message, setMessage] = useState('This modal example uses the modalController to present and dismiss modals.');

Expand Down