Skip to content

docs(dark-mode): replace deprecated addListener() usage #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 17, 2023
Merged

docs(dark-mode): replace deprecated addListener() usage #1908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
822aa6c
Replace deprecated API usage in dark mode documentation
eyecatchup May 4, 2021
cd8a626
Merge branch 'main' of github.com:ionic-team/ionic-docs into patch-1
thetaPC May 16, 2023
90358e3
docs(dark-mode): switch to addEventListener
thetaPC May 17, 2023
220a2b6
fix(dark-mode): add listener type
thetaPC May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/theming/dark-mode.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ const prefersDark = window.matchMedia('(prefers-color-scheme: dark)');
toggleDarkTheme(prefersDark.matches);

// Listen for changes to the prefers-color-scheme media query
prefersDark.addListener((mediaQuery) => toggleDarkTheme(mediaQuery.matches));
prefersDark.addEventListener('change', (mediaQuery) => toggleDarkTheme(mediaQuery.matches));

// Add or remove the "dark" class based on if the media query matches
function toggleDarkTheme(shouldAdd) {
Expand Down Expand Up @@ -106,7 +106,7 @@ toggle.addEventListener('ionChange', (ev) => {
const prefersDark = window.matchMedia('(prefers-color-scheme: dark)');

// Listen for changes to the prefers-color-scheme media query
prefersDark.addListener((e) => checkToggle(e.matches));
prefersDark.addEventListener('change', (e) => checkToggle(e.matches));

// Called when the app loads
function loadApp() {
Expand Down
4 changes: 2 additions & 2 deletions versioned_docs/version-v5/theming/dark-mode.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ const prefersDark = window.matchMedia('(prefers-color-scheme: dark)');
toggleDarkTheme(prefersDark.matches);

// Listen for changes to the prefers-color-scheme media query
prefersDark.addListener((mediaQuery) => toggleDarkTheme(mediaQuery.matches));
prefersDark.addEventListener('change', (mediaQuery) => toggleDarkTheme(mediaQuery.matches));

// Add or remove the "dark" class based on if the media query matches
function toggleDarkTheme(shouldAdd) {
Expand Down Expand Up @@ -99,7 +99,7 @@ toggle.addEventListener('ionChange', (ev) => {
const prefersDark = window.matchMedia('(prefers-color-scheme: dark)');

// Listen for changes to the prefers-color-scheme media query
prefersDark.addListener((e) => checkToggle(e.matches));
prefersDark.addEventListener('change', (e) => checkToggle(e.matches));

// Called when the app loads
function loadApp() {
Expand Down
4 changes: 2 additions & 2 deletions versioned_docs/version-v6/theming/dark-mode.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ const prefersDark = window.matchMedia('(prefers-color-scheme: dark)');
toggleDarkTheme(prefersDark.matches);

// Listen for changes to the prefers-color-scheme media query
prefersDark.addListener((mediaQuery) => toggleDarkTheme(mediaQuery.matches));
prefersDark.addEventListener('change', (mediaQuery) => toggleDarkTheme(mediaQuery.matches));

// Add or remove the "dark" class based on if the media query matches
function toggleDarkTheme(shouldAdd) {
Expand Down Expand Up @@ -106,7 +106,7 @@ toggle.addEventListener('ionChange', (ev) => {
const prefersDark = window.matchMedia('(prefers-color-scheme: dark)');

// Listen for changes to the prefers-color-scheme media query
prefersDark.addListener((e) => checkToggle(e.matches));
prefersDark.addEventListener('change', (e) => checkToggle(e.matches));

// Called when the app loads
function loadApp() {
Expand Down