Installer final tweaks #1550
Merged
Installer final tweaks #1550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows populating setup.py's 'install_requires' directly from 'requirements.in' - setup.py: - read 'requirements.in' instead of 'requirements.txt' - add correct upstream pytorch repo to "dependency_links" - requirements.in: - append "name @" to git packages - fix torch repo URL -> 'download.pytorch.org/whl/torch_stable.html' Signed-off-by: Ben Alkov <[email protected]>
Collaborator
Author
|
@tildebyte PR #1537 was failing CI tests because of two |
1. removed redundant `data_files` argument from setup.py 2. upped requirement to Python >= 3.9. This is due to a feature used in `argparse` that is only available in 3.9 or higher.
- conflicts with their counterparts in the environment files was causing the CI conda-based tests to fail. - installer seems to work still
Collaborator
Author
|
Seems to be working. Just ran installer on linux system and it worked flawlessly. |
blessedcoolant
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as PR #1537 except that it removes a redundant
scriptsargument fromsetup.pythat appeared at some point.I also had to unpin the github dependencies in
requirements.inin order to get conda CI tests to pass. However, dependencies are still pinned inrequirements-base.txtand the environment files, and install itself is working. So I think we are good.