add k_dpmpp_2_a and k_dpmpp_2 solvers options #1383
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstein
requested changes
Nov 5, 2022
Collaborator
lstein
left a comment
lstein
left a comment
There was a problem hiding this comment.
Thank you so much for this. The PR seems to contain irrelevant changes to some of the front end files in dist/assets, and it is based against main. Could you rebase against a fresh pull of development instead and repost?
Contributor
Author
|
Done in a new draft PR! Will close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes needed in case anyone wants to test the new DPM++ solvers (crowsonkb/k-diffusion@2d2240b).
On Mac M1 k_dpmpp_2 results in black images, the ancestral k_dpmpp_2_a works, but I think it suffers from the same as #1350 , so it might work better elsewhere.
To use, k-diffusion (src/k-diffusion/k_diffusion/sampling.py) has to be updated with the sample_dpmpp_2s_ancestral() and sample_dpmpp_2m() functions. Might be interesting to evaluate these new versions. More info: crowsonkb/k-diffusion#40