Skip to content

Conversation

@abisalehalliprasan
Copy link
Collaborator

New Release Candidate: 2.1.0 🎉

Features :
1.) Accept Full Range of HTTP Success Codes #78
2.) Handle not JSON content in response parsing #59
3.) Dependency cleanup

zinaschroeder and others added 6 commits April 10, 2020 15:08
* Coveralls Badge Fix

* Coveralls Badge Fix:Final

* Coveralls Badge Fix : istanbul package added

* Coveralls Badge Fix + snyk added

* Coveralls Badge Fix + snyk added

* Snyk removed from Makefile

* Snyk removed for timebeing

* Add more code coverage for OAuthClient (#54)

* Add better code coverage in OAuthClient

* Fix: ValidateIdToken method and unit tests (#58)

* Fix validateIdToken tests

* Pointing README Badge to Develop

* Pointing README Badge to Develop

* Update Develop Coverage Badge

* Fix: handle not JSON content in response parsing

Some intuit API as invoice download return not JSON content (PDF in this
case). `makeApiCall` wasn't working with it because of mandatory
response body parsing.

So if the response is not JSON, we don't want to parse the body.
And simply let the caller decide what to do with it.

Co-authored-by: abisalehalliprasan <[email protected]>
Co-authored-by: Oscar Rabasa <[email protected]>
Co-authored-by: Kevin Tang <[email protected]>
Co-authored-by: abisalehalliprasan <[email protected]>
@abisalehalliprasan
Copy link
Collaborator Author

Thanks @zinaschroeder @sebastien-cleany 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants