Skip to content

Add more code coverage for OAuthClient #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 18, 2019
Merged

Add more code coverage for OAuthClient #54

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca5bace
Add better code coverage in OAuthClient
oscargrp Oct 18, 2019
d5dd4f1
Add better code coverage in OAuthClient
oscargrp Oct 18, 2019
e4a1c2f
Add better code coverage in OAuthClient
oscargrp Oct 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion test/OAuthClientTest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ describe('Tests for OAuthClient', () => {
});

// make API Call
describe('Make API Call ', () => {
describe('Make API Call', () => {
before(() => {
nock('https://sandbox-quickbooks.api.intuit.com').persist()
.get('/v3/company/12345/companyinfo/12345')
Expand All @@ -285,6 +285,20 @@ describe('Tests for OAuthClient', () => {
.to.be.equal(JSON.stringify(expectedMakeAPICall));
});
});
it('Make API Call in Sandbox Environment with headers as parameters', () => {
oauthClient.getToken().realmId = '12345';
// eslint-disable-next-line no-useless-concat
return oauthClient.makeApiCall({
url: 'https://sandbox-quickbooks.api.intuit.com/v3/company/' + '12345' + '/companyinfo/' + '12345',
headers: {
Accept: "application/json",
}
})
.then((authResponse) => {
expect(JSON.stringify(authResponse.getJson()))
.to.be.equal(JSON.stringify(expectedMakeAPICall));
});
});
it('loadResponseFromJWKsURI', () => {
const request = {
url: 'https://sandbox-quickbooks.api.intuit.com/v3/company/12345/companyinfo/12345',
Expand Down Expand Up @@ -474,6 +488,10 @@ describe('Generate OAuth1Sign', () => {

const oauth1Sign = oauthClient.generateOauth1Sign(params);
expect(oauth1Sign).to.be.a('String');
expect(oauth1Sign).to.have.string('oauth_consumer_key="qyprdFsHNQtdRupMKmYnDt6MOjWBW9');
expect(oauth1Sign).to.have.string('oauth_nonce="nonce');
expect(oauth1Sign).to.have.string('oauth_version="1.0');
expect(oauth1Sign).to.have.string('oauth_token', 'oauth_timestamp', 'oauth_signature');
});
});

Expand Down