Skip to content

Conversation

@efredin
Copy link

@efredin efredin commented Oct 3, 2019

Adds typescript support. Re-opened targeting new typescript branch on request of @abisalehalliprasan

In order to avoid adding external typing dependencies, I've left log() typings fairly generic. There is an @types/winston package available, but its probably not necessary.

@abisalehalliprasan
Copy link
Collaborator

Thanks @efredin will test it and get back to you

@efredin
Copy link
Author

efredin commented Oct 18, 2019

Anything I can contribute to help validate the typings?

@abisalehalliprasan
Copy link
Collaborator

@efredin : Thanks for checking with us. I am not too familiar with typescript, so would be helpful if you could show me how to use index.d.ts in the sample

I will be merging this PR into typescript branch and create a new issue for the sample. Does that work with you?

@efredin
Copy link
Author

efredin commented Oct 18, 2019

@abisalehalliprasan That works for me. I should be able to put some time to this next week.

The typings won't impact any javascript consumers. I can update the sample in that branch to a typescript project and run it through the typescript compiler to demonstrate things are working as expected.

@abisalehalliprasan
Copy link
Collaborator

@efredin : Awesome thanks

@abisalehalliprasan abisalehalliprasan merged commit fb84163 into intuit:typescript Oct 18, 2019
@abisalehalliprasan
Copy link
Collaborator

🚀 PR was released in branch typescript for hacktoberfest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants