Check for JSON before parsing JSON in errors #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The createError function was incorrectly assuming that response bodies are in JSON format and attempting to extract useful details from that body. But, for some error cases, the body is not JSON resulting in a error being thrown during the process of adding details to the error. This fix adds safeguards around the places that need JSON to enable the createError method to extract the useful details.
JimPatterson
force-pushed
the
fix_error_reporting
branch
from
f4c0616 to
6c725cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The createError function was incorrectly assuming that response
bodies are in JSON format and attempting to extract useful details
from that body. But, for some error cases, the body is not JSON
resulting in a error being thrown during the process of adding
details to the error.
This fix adds safeguards around the places that need JSON to enable
the createError method to extract the useful details.
This likely fixes #110 and fixes #118.