Skip to content

Conversation

@VeenaDesai38
Copy link

@VeenaDesai38 VeenaDesai38 commented Oct 21, 2020

Enum, Interface, Class defined in index.d.ts are the implementation details. Unit tests that validate the behavior of the enums already exists in test module.
The changes in types.test.ts are only meant to test the types and whether the mandatory fields are returned or not.
Not the actual value returned by the fields.
This file doesn't add to the coverage as nothing is executable.

Screen Shot 2020-10-22 at 2 35 32 AM

@VeenaDesai38
Copy link
Author

@abisalehalliprasan Please review this PR.

@abisalehalliprasan
Copy link
Collaborator

Thanks @VeenaDesai38 for the contribution 🚀

@abisalehalliprasan abisalehalliprasan merged commit cd8f862 into intuit:typescript Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants