-
-
Notifications
You must be signed in to change notification settings - Fork 377
Update component.md to explain it doesn't work in petite vue #2259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughDocumentation update: added a warning admonition to docs/guide/advanced/component.md noting unavailability in petite-vue-i18n. No code or API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks (2 passed, 1 inconclusive)❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/guide/advanced/component.md (1)
275-277
: Clarify the unavailability and align admonition style.Be explicit that the Translation component is the thing not supported, use code formatting for the package name, add a period, and consider using LIMITATION to match the earlier admonition style on Line 186. petite-vue-i18n officially omits the
i18n-t
component. (vue-i18n.intlify.dev, github.com)-:::warning NOTE -This is not available in petite-vue-i18n +:::warning LIMITATION +The Translation component (`i18n-t`) is not available in `petite-vue-i18n`. :::
Summary by CodeRabbit