fix: typo #2222
fix: typo #2222
Conversation
WalkthroughThis update standardizes the spelling of the constant Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CoreContext
participant Constants
User->>CoreContext: Request translation/number/datetime
CoreContext->>Constants: Check for resolved value
alt Not resolved
CoreContext-->>User: Return NOT_RESOLVED
else Resolved
CoreContext-->>User: Return resolved value
end
Suggested labels
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Deploying vue-i18n-next with
|
| Latest commit: |
c52ee7b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f4806872.vue-i18n-next.pages.dev |
| Branch Preview URL: | https://fix-core-base-typo-v12.vue-i18n-next.pages.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
examples/storybook/index.html (1)
4-6: Avoid mixing XHTML-style self-closing tags in HTML5
<meta>and<link>are void elements, so the extra/>is optional. If the rest of the codebase omits it, consider reverting to<meta …>/<link …>for stylistic consistency.packages/shared/package.json (1)
5-9: Typo in keyword list:utitlity→utilityWhile outside the scope of the current change, fixing this misspelling will improve searchability on npm.
- "intlify", - "utitlity" + "intlify", + "utility"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (17)
examples/storybook/index.html(1 hunks)packages/core-base/package.json(1 hunks)packages/core-base/src/context.ts(1 hunks)packages/core-base/src/datetime.ts(2 hunks)packages/core-base/src/number.ts(2 hunks)packages/core-base/src/translate.ts(2 hunks)packages/core-base/test/datetime.test.ts(3 hunks)packages/core-base/test/number.test.ts(3 hunks)packages/core-base/test/translate.test.ts(3 hunks)packages/core/package.json(1 hunks)packages/devtools-types/package.json(1 hunks)packages/message-compiler/package.json(1 hunks)packages/petite-vue-i18n/package.json(1 hunks)packages/shared/package.json(1 hunks)packages/vue-i18n-core/package.json(1 hunks)packages/vue-i18n-core/src/composer.ts(2 hunks)packages/vue-i18n/package.json(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (7)
packages/core-base/src/number.ts (1)
packages/core-base/src/context.ts (1)
NOT_RESOLVED(339-339)
packages/core-base/src/datetime.ts (1)
packages/core-base/src/context.ts (1)
NOT_RESOLVED(339-339)
packages/core-base/test/number.test.ts (2)
packages/core-base/src/number.ts (1)
number(185-290)packages/core-base/src/context.ts (1)
NOT_RESOLVED(339-339)
packages/core-base/src/translate.ts (2)
packages/core-base/src/context.ts (1)
NOT_RESOLVED(339-339)packages/core-base/src/runtime.ts (1)
MessageFunctionReturn(76-78)
packages/core-base/test/datetime.test.ts (2)
packages/core-base/src/datetime.ts (1)
datetime(190-295)packages/core-base/src/context.ts (1)
NOT_RESOLVED(339-339)
packages/core-base/test/translate.test.ts (2)
packages/core-base/src/translate.ts (1)
translate(614-802)packages/core-base/src/context.ts (1)
NOT_RESOLVED(339-339)
packages/vue-i18n-core/src/composer.ts (1)
packages/core-base/src/context.ts (1)
NOT_RESOLVED(339-339)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: upload
- GitHub Check: Build (windows-latest, 20)
- GitHub Check: Unit test (windows-latest, 22)
- GitHub Check: Unit test (windows-latest, 20)
- GitHub Check: Build (ubuntu-latest, 20)
- GitHub Check: Build (macos-latest, 20)
- GitHub Check: release
- GitHub Check: release
🔇 Additional comments (25)
examples/storybook/index.html (1)
1-1: Lower-case DOCTYPE is perfectly valid
<!doctype html>is functionally identical to the previous upper-case form in HTML5—no action needed.packages/vue-i18n/package.json (1)
80-82: Order-only change, no functional impact – looks goodRe-locating
"type": "module"after"sideEffects"is a cosmetic re-ordering; JSON property order is ignored by tooling. No risk introduced.packages/vue-i18n-core/package.json (1)
86-88: Consistent re-ordering acknowledgedSame non-functional move of
"type": "module"beneath"sideEffects". File now ends cleanly with no dangling comma – all good.packages/core/package.json (1)
73-75: LGTMPure re-ordering; validates against
npm pack --dry-runwithout warnings. 👍packages/core-base/package.json (1)
71-73: No issues foundCosmetic relocation only; JSON remains valid and consistent with other packages.
packages/message-compiler/package.json (1)
70-72: Change approvedOrdering tweak confirmed; nothing else altered.
Minor note: keeping the same field order across every package.json (sideEffects → type) helps diff readability—current patch already follows that.packages/shared/package.json (1)
59-60: Change is harmless – ordering of keys inpackage.jsonis non-semanticRelocating the
"type": "module"field next to"sideEffects": falsedoes not affect consumers and keeps the layout consistent with other package manifests in the repo.packages/petite-vue-i18n/package.json (1)
80-82: Consistent field positioning looks goodSame non-functional shuffle as in other packages – no issues spotted.
packages/devtools-types/package.json (1)
62-64: No concerns with the key re-orderingThe move keeps manifests uniform across workspaces; behaviour remains unchanged.
packages/core-base/src/context.ts (1)
339-339: LGTM! Typo fixed in constant definition.The
NOT_RESOLVEDconstant is now correctly spelled. This fix ensures consistency across the entire codebase.packages/core-base/test/number.test.ts (2)
26-26: LGTM! Import statement corrected.The import of
NOT_RESOLVEDnow uses the correct spelling, consistent with the fixed constant definition.
243-243: LGTM! Test assertions updated with correct constant spelling.Both test assertions in the "context unresolving option" suite now correctly reference
NOT_RESOLVED, ensuring tests will pass with the fixed constant definition.Also applies to: 262-262
packages/core-base/src/number.ts (2)
14-14: LGTM! Import statement corrected.The import of
NOT_RESOLVEDnow uses the correct spelling, ensuring proper reference to the fixed constant definition.
273-273: LGTM! Usage updated with correct constant spelling.The return statement now correctly references
NOT_RESOLVEDwhen the unresolving option is enabled and format resolution fails.packages/core-base/src/datetime.ts (2)
15-15: LGTM! Import statement corrected.The import of
NOT_RESOLVEDnow uses the correct spelling, consistent with the fixed constant definition.
278-278: LGTM! Usage updated with correct constant spelling.The return statement now correctly references
NOT_RESOLVEDwhen the unresolving option is enabled and datetime format resolution fails.packages/core-base/test/datetime.test.ts (2)
26-26: LGTM! Import statement corrected.The import of
NOT_RESOLVEDnow uses the correct spelling, ensuring consistency with the fixed constant definition.
269-269: LGTM! Test assertions updated with correct constant spelling.Both test assertions in the "context unresolving option" suite now correctly reference
NOT_RESOLVED, ensuring tests will pass with the fixed constant definition.Also applies to: 288-288
packages/core-base/src/translate.ts (2)
21-28: Typo fixed – import is now correctly referencingNOT_RESOLVED.
The constant name now matches the definition incontext.ts, avoiding the previous undefined-identifier issue.
706-717: Return-path now uses the right sentinel constant.
The early-return branch correctly compares againstNOT_RESOLVED, restoring the missing-translation sentinel flow. No further action required.packages/vue-i18n-core/src/composer.ts (2)
1-7: Import typo corrected –NOT_RESOLVEDis resolved.
This prevents runtimeundefinederrors when the composer evaluates unresolved translations.
2236-2241: Fallback detection condition fixed.
The check now hits the intendedNOT_RESOLVEDsentinel, ensuring proper root fallback behaviour. Looks good.packages/core-base/test/translate.test.ts (3)
19-19: LGTM! Critical typo fix in import statement.The import statement now correctly references
NOT_RESOLVEDinstead of the typoNOT_REOSLVED. This fix is essential for the tests to work properly.
556-556: LGTM! Correct usage of the fixed constant.The test assertion properly expects
NOT_RESOLVEDto be returned when theunresolvingoption is enabled and the message cannot be resolved.
571-571: LGTM! Correct usage of the fixed constant.The test assertion properly expects
NOT_RESOLVEDto be returned when theunresolvingoption is enabled and the message cannot be resolved.
@intlify/core
@intlify/core-base
@intlify/devtools-types
@intlify/message-compiler
petite-vue-i18n
@intlify/shared
vue-i18n
@intlify/vue-i18n-core
commit: |
Size ReportBundles
Usages
|
back port from #2221
Summary by CodeRabbit
Bug Fixes
NOT_REOSLVEDtoNOT_RESOLVED, ensuring consistent fallback behavior in translation, number, and datetime formatting features.Chores
"type": "module"field to the end of multiple package configuration files for improved consistency.