Added a comment about pluralRules to the code in pluralization docs #1873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M1h4n1k
changed the title
kazupon
approved these changes
Jul 15, 2024
Member
kazupon
left a comment
kazupon
left a comment
There was a problem hiding this comment.
Sorry, my late response
We appreciate your PR!
Thank you !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed meaningless comment and replaced it with more useful comment about
pluralRulesfor Composition api.If the code is understandable I am just copying it and I'm not really reading through the documentation, and seems like many people do it the same way. However, in the docs there is a very important note. So, there is a higher chance that people will notice it if it's put directly into the code.
I've actually done the same mistake in 2 different projects. Luckily, at the second time I remembered that there was something wrong with docs and it didn't take me very long, but at the first time I spent quite a lot of time