Skip to content

Fix Unicode encoding of Git commands from web UI #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Fix Unicode encoding of Git commands from web UI #628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80a160b
fix: need to convert UTF encoding of CSP stream before JSON input
isc-pbarton Nov 7, 2024
4cb7803
chore: fix version in changelog and manifest
isc-pbarton Nov 7, 2024
a97f823
Merge branch 'main' into commit-encoding
isc-tleavitt Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [2.7.1] - Unreleased

### Fixed
- Fixed improper encoding of unicode characters in commit messages (#627)
- Creating a new branch now reports the error if uncommitted changes conflict (#624)

## [2.7.0] - 2024-11-04
Expand Down
7 changes: 6 additions & 1 deletion cls/SourceControl/Git/WebUIDriver.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,12 @@ ClassMethod HandleRequest(pagePath As %String, InternalName As %String = "", Out
}
set handled = 1
} elseif (pathStart = "git-command") {
set requestBody = ##class(%Library.DynamicObject).%FromJSON(%request.Content)
set stringBody = ""
while '%request.Content.AtEnd {
set stringBody = stringBody _ %request.Content.Read()
}
set stringBody = $zconvert(stringBody,"I","UTF8")
set requestBody = ##class(%Library.DynamicObject).%FromJSON(stringBody)
set command = requestBody.command

set gitCmd = command.%Get(0)
Expand Down
Loading