Skip to content

Fix <PROTECT> errors rendering menus #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 14, 2023
Merged

Fix <PROTECT> errors rendering menus #244

merged 2 commits into from
Feb 14, 2023

Conversation

isc-tleavitt
Copy link
Collaborator

@isc-tleavitt isc-tleavitt commented Feb 10, 2023 •
edited
Loading

Fixes #243

Solution:

  • Wrap references to IRISSYS namespace globals in try/catch
  • Duplicate git bin config in local namespace in addition to instance-wide default (doesn't matter for default temp folder because this is saved first time it's configured)

isc-pbarton
isc-pbarton reviewed Feb 14, 2023
View reviewed changes
@isc-tleavitt isc-tleavitt merged commit 0bde722 into main Feb 14, 2023
@isc-tleavitt isc-tleavitt deleted the fix-protect-errors branch February 14, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isc-pbarton isc-pbarton isc-pbarton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#5002 Error, <Protect> loading Source control menu
2 participants
@isc-tleavitt @isc-pbarton