Skip to content
This repository was archived by the owner on Aug 7, 2024. It is now read-only.

Conversation

Corsair-cxs
Copy link
Contributor

@Corsair-cxs Corsair-cxs commented Mar 14, 2021

Achive #113
What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: Add issue template and pull_request template

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Reference

https://github.com/vuejs/vue/blob/dev/.github/COMMIT_CONVENTION.md

@LewisLiuPub
Copy link
Contributor

good template.
But before merging, I need to have a line-to-line review with you. we need suitable steps and templates, try to make them simple and clear, rather than too complex.

Copy link
Contributor

@LewisLiuPub LewisLiuPub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like it is not good to store such .md files under folder .github/?

@LewisLiuPub
Copy link
Contributor

I will arrange a review meeting with you, you needn't do anything about its updating before the meeting. @Corsair-cxs.

Thanks.

@Corsair-cxs
Copy link
Contributor Author

I will arrange a review meeting with you, you needn't do anything about its updating before the meeting. @Corsair-cxs.

Thanks.

OK!

@LewisLiuPub
Copy link
Contributor

we'll merge this PR first and say any updates to be needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants