Skip to content

Conversation

@jb-balaji
Copy link

  • Creating docker container for ROS2 Humble with OpenVINO 2025.2.0
  • Updated the docker file for ros2 humble and it can support OpenVINO 2023.3 LTS
  • Jazzy support added, for that librealsense library building inside docker, code is compiling without any error
  • ROS2 Jazzy docker - Refactoring of the dockerfile, add nano package
  • Created the README document to build, setup and run the docker container

--> Updated the docker file for ros2 humble and it can support OpenVINO 2023.3 LTS
--> Jazzy support added, for that librealsense library building inside docker, code is compiling without any error
--> ROS2 Jazzy docker - Refactoring of the dockerfile, add nano package
--> Created the README document to build, setup and run the docker container

Signed-off-by: Sathiyamoorthi, Jayabalaji <[email protected]>
@jb-balaji jb-balaji marked this pull request as ready for review July 22, 2025 09:10
@jb-balaji jb-balaji requested a review from Copilot October 7, 2025 13:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for ROS2 Jazzy distribution alongside updates to the existing ROS2 Humble Docker configuration. The changes update OpenVINO version references and add a complete Docker setup for ROS2 Jazzy.

  • Updates default OpenVINO version from 2025.0.0 to 2025.2.0 in ROS2 Humble configuration
  • Adds conditional repository configuration logic for OpenVINO 2025 versions
  • Creates complete ROS2 Jazzy Docker environment with OpenVINO 2025.2.0 support

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
sample/param/pipeline_image.yaml Updates sample image path to specific test file
openvino_param_lib/CMakeLists.txt Adds explicit libyaml-cpp library linking
docker/ros2_ov202x/ros2_humble/docker_instructions.md Updates documentation to reflect OpenVINO 2025.2.0 as default
docker/ros2_ov202x/ros2_humble/Dockerfile Updates default OpenVINO version and adds conditional repository logic
docker/ros2_ov2025/ros2_jazzy/docker_instructions.md Adds comprehensive documentation for ROS2 Jazzy Docker setup
docker/ros2_ov2025/ros2_jazzy/Dockerfile Creates new Dockerfile for ROS2 Jazzy with OpenVINO 2025.2.0

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

- name: people
inputs: [Image]
input_path: to/be/set/image_path
input_path: /home/skl/catkin_ws/src/ros2_openvino_toolkit/data/images/sample_faces.jpg
Copy link

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardcoded path '/home/skl/catkin_ws/' contains a specific username 'skl' which makes it non-portable across different environments. Consider using a relative path or environment variable.

Suggested change
input_path: /home/skl/catkin_ws/src/ros2_openvino_toolkit/data/images/sample_faces.jpg
input_path: ${HOME}/catkin_ws/src/ros2_openvino_toolkit/data/images/sample_faces.jpg

Copilot uses AI. Check for mistakes.
ament_target_dependencies(${PROJECT_NAME}
"yaml_cpp_vendor"
)
target_link_libraries(${PROJECT_NAME} /usr/lib/x86_64-linux-gnu/libyaml-cpp.so)
Copy link

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded library path '/usr/lib/x86_64-linux-gnu/libyaml-cpp.so' is not portable across different architectures and distributions. Use find_package(yaml-cpp) or pkg_config to locate the library properly.

Copilot uses AI. Check for mistakes.
Comment on lines +47 to +48
#change the branch before merge
RUN git clone -b ros2_jazzy https://github.com/jb-balaji/ros2_openvino_toolkit.git
Copy link

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a personal GitHub repository 'jb-balaji/ros2_openvino_toolkit' instead of the official Intel repository may introduce maintenance and reliability concerns for production use.

Suggested change
#change the branch before merge
RUN git clone -b ros2_jazzy https://github.com/jb-balaji/ros2_openvino_toolkit.git
# Use the official Intel repository for ros2_openvino_toolkit
RUN git clone https://github.com/intel/ros2_openvino_toolkit.git

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant