Skip to content
This repository was archived by the owner on Aug 5, 2022. It is now read-only.

Conversation

@sguiriec
Copy link

@sguiriec sguiriec commented Feb 2, 2017

This patch is adding basic test for Logarithmic format.

Signed-off-by: Sebastien Guiriec [email protected]

Merging #402 into master will increase coverage by 0.34%.

@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
+ Coverage    72.7%   73.04%   +0.34%
==========================================
Files         214      214
Lines        6674     6674
Branches      845      845
==========================================
+ Hits         4852     4875      +23
+ Misses       1355     1330      -25
- Partials      467      469       +2
Impacted Files Coverage Δ
parameter/BaseIntegerParameterType.cpp 100% <ø> (+14.28%)
parameter/LinearParameterAdaptation.cpp 18.18% <ø> (+18.18%)
parameter/ParameterAdaptation.cpp 21.05% <ø> (+21.05%)
parameter/LogarithmicParameterAdaptation.cpp 38.09% <ø> (+38.09%)
parameter/LinearParameterAdaptation.h 100% <ø> (+100%)
parameter/ParameterAdaptation.h 100% <ø> (+100%)
parameter/LogarithmicParameterAdaptation.h 100% <ø> (+100%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf265b1...d8f1b76. Read the comment docs.

  

This patch is adding basic test for Logarithmic format.

Signed-off-by: Sebastien Guiriec <[email protected]>
@codecov-io
Copy link

codecov-io commented Feb 2, 2017

Codecov Report

Merging #402 into master will increase coverage by 1.9%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master    #402     +/-   ##
========================================
+ Coverage    72.7%   74.6%   +1.9%     
========================================
  Files         214     214             
  Lines        6674    6675      +1     
  Branches      845     845             
========================================
+ Hits         4852    4980    +128     
+ Misses       1355    1224    -131     
- Partials      467     471      +4
Impacted Files Coverage Δ
parameter/BooleanParameterType.cpp 100% <100%> (+50%)
parameter/ElementHandle.cpp 63.76% <ø> (+2.89%)
parameter/ParameterType.cpp 58.75% <ø> (+3.75%)
parameter/Parameter.cpp 85.18% <ø> (+5.55%)
parameter/EnumParameterType.cpp 89.58% <ø> (+13.54%)
parameter/IntegerParameterType.h 81.9% <ø> (+14.28%)
parameter/BaseIntegerParameterType.cpp 100% <ø> (+14.28%)
parameter/BitParameterType.cpp 89.61% <ø> (+25.97%)
parameter/BitParameter.cpp 69.23% <ø> (+26.92%)
parameter/LogarithmicParameterAdaptation.cpp 38.09% <ø> (+38.09%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf265b1...36497d5. Read the comment docs.

Sebastien Guiriec added 3 commits February 3, 2017 09:50
Integer parameter cannot be set in double format except in case of
Linear or Logarithm Adaptation format.

Signed-off-by: Sebastien Guiriec <[email protected]>
This patch is adding Linear adaptation format unit test
for Parameter Framework.

Signed-off-by: Sebastien Guiriec <[email protected]>
Fix missing false return for backboard synchronization.

Signed-off-by: Sebastien Guiriec <[email protected]>
@sguiriec sguiriec force-pushed the topic/coverage branch 2 times, most recently from 3477290 to 75f6534 Compare February 3, 2017 14:16
Sebastien Guiriec added 4 commits February 3, 2017 16:15
This patch is improving Boolean parameter Ynit test for setting in
the different possible formats.

Signed-off-by: Sebastien Guiriec <[email protected]>
Improve test coverage of BitParameter format.

Signed-off-by: Sebastien Guiriec <[email protected]>
Add few additional test for Integer parameter in Hexa format.

Signed-off-by: Sebastien Guiriec <[email protected]>
Improve EnumParameter test coverage.

Signed-off-by: Sebastien Guiriec <[email protected]>
Add missing Boolean type setting test for Blackboard synchronization

Signed-off-by: Sebastien Guiriec <[email protected]>
@sguiriec
Copy link
Author

@gdenneul Please review

Add BitParamter tests cases for boolean type format.

Signed-off-by: Sebastien Guiriec <[email protected]>
@sguiriec sguiriec merged commit e678467 into intel:master Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants