This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Decorrelating auto-sync and tuning-mode #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcahuzax
force-pushed
the
autosync_update
branch
from
9183513 to
3e2c568
Compare
tcahuzax
changed the title
tcahuzax
force-pushed
the
autosync_update
branch
3 times, most recently
from
26b00cb to
0715449
Compare
tcahuzax
changed the title
Contributor
Author
Currently auto-sync can be disabled in tuning mode only. This patch decorrelates auto-sync and tnuning mode features: they can be activated independently. Signed-off-by: Thomas Cahuzac <[email protected]>
tcahuzax
force-pushed
the
autosync_update
branch
2 times, most recently
from
dcc8877 to
6a269f8
Compare
Contributor
|
In the "Adding the ability to set configuration value" and "Allowing to choose the subsystem type" commit messages, please add a context information in the headline: as they stand, they seem to suggest, for instance, that the Parameter Framework does not provide the ability to set a configuration value at all. |
tcahuzax
force-pushed
the
autosync_update
branch
4 times, most recently
from
909b8e5 to
caa584c
Compare
Contributor
Author
Contributor
There was a problem hiding this comment.
(const std::string& name, core::log::Logger& logger)
Contributor
There was a problem hiding this comment.
Remove virtual as it is redundant with override.
tcahuzax
force-pushed
the
autosync_update
branch
from
caa584c to
926f83f
Compare
Contributor
There was a problem hiding this comment.
ALWAYS_ASSERT(geParameterType(instanceConfigurableElement)->isScalar(),
"Parameter shall be scalar");Don't need to do it though.
Functional testing auto-sync feature requires a fake subsystem that allows to retrieve parameter value set by the parameter-framework. This patch introduces the introspection-subsystem, it provides the ability to retrieve the value of a boolean parameter. Signed-off-by: Thomas Cahuzac <[email protected]>
This patch allows the pfw test wrapper to set configuration values. Signed-off-by: Thomas Cahuzac <[email protected]>
Currently the subsystem type used by the functional test framework is always "Virtual". This patch provides the ability to change it. Signed-off-by: Thomas Cahuzac <[email protected]>
This feature was not test. This patch introduces a functional test that uses the instrospection subsystem to check the auto-sync feature. Two sequences are tested: - when auto-sync is activated, parameter sync occurs when a parameter is changed in the blackboard. - when auto-sync is off, parameter sync occurs when tha auto-sync is turned to on. Signed-off-by: Thomas Cahuzac <[email protected]>
tcahuzax
force-pushed
the
autosync_update
branch
from
926f83f to
6aa22a1
Compare
Contributor
Author
Contributor
|
You still have 1 alignment wrong: #317 (comment) |
dawagner
added a commit
that referenced
this pull request
Dec 4, 2015
Decorrelating auto-sync and tuning mode Auto-sync and tuning mode can now be activated independently.
krocard
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thomas Cahuzac [email protected]
@dawagner @krocard plz review
👍 after that.
Coverage decreased (-43.3%) to 31.67% when pulling 6aa22a1 on tcahuzax:autosync_update into 705008b on 01org:master.
(const std::string& name, core::log::Logger& logger)namesubsystemLibraryinstanceConfigurableElementSubsystem(const std::string &name, core::log::Logger &logger)core::log::Logger &loggerconst CParameterType *geParameterType(CInstanceConfigurableElement *element)&and*are to right align.CMappingContext &contextcore::log::Logger &loggervirtualas it is redundant withoverride.ALWAYS_ASSERT(geParameterType(instanceConfigurableElement)->isScalar(),
"Parameter shall be scalar");