This repository was archived by the owner on Aug 5, 2022. It is now read-only.
LegacyAmixerControl: fix bytes control support mapped to component type #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please give more details in the commit message: you didn't explain why to/fromBlackboard does not work. |
| if (isDebugEnabled()) { | ||
|
|
||
| // The "info" method has been shadowed by a local variable | ||
| this->info() << "Writing alsa element " << controlName |
Contributor
There was a problem hiding this comment.
With this patch, that log isn't produced in case of byte controls anymore. (Same issue applies when reading alsa byte controls).
Contributor
Author
There was a problem hiding this comment.
yes but one bytes per line, if you have at worst 512 bytes is not really helpfull.
So just skip as done in TLV bytes control
Contributor
There was a problem hiding this comment.
Sure but you could come up with a smarter way to log.
mgaio
force-pushed
the
topic/legacy-bytes-control
branch
from
9fe36c6 to
0edf481
Compare
Contributor
|
👍 Lots of specific code for Bit array. It will need to be factorized one day. |
mgaio
force-pushed
the
topic/legacy-bytes-control
branch
from
0edf481 to
b4ef15e
Compare
When bytes control is mapped to component type, PFW scalar size is the whole size of amixer bytes control, this does not match scalar size of a byte. Thus, the call of to/from Blackboard() calls can not be used. To handle this case, use blackboardWrite() and blackboardRead() for hw access. Signed-off-by: Miguel Gaio <[email protected]>
mgaio
force-pushed
the
topic/legacy-bytes-control
branch
from
b4ef15e to
913efde
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bytes control is mapped to component type, to/from Blackboard() calls
can not be used.
In this case, blackboard has to be accessed using blackboardWrite() and
blackboardRead()
Signed-off-by: Miguel Gaio [email protected]