Skip to content

Adding missing check in QuantileQuantizedPerAxisType::verify #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Adding missing check in QuantileQuantizedPerAxisType::verify #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b88b09
Adding missing check in QuantileQuantizedPerAxisType::verify
sartil Oct 9, 2024
f2db4dd
Adding minor test for illegal quantile array size for per axis type
sartil Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions mlir/lib/Dialect/Quant/IR/QuantTypes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,6 @@ LogicalResult QuantileQuantizedPerAxisType::verify(
return failure();
}

const auto quantileArraySize = quantiles.size();
unsigned typeWidth{};
if (storageType.isa<IntegerType>()) {
typeWidth = llvm::dyn_cast<IntegerType>(storageType).getWidth();
Expand All @@ -517,10 +516,17 @@ LogicalResult QuantileQuantizedPerAxisType::verify(
"types, Float8E4M3FNType and Float8E5M2Type ";
}

const size_t expectedSize = 1 << typeWidth;
const size_t storageTypeRange = storageTypeMax - storageTypeMin + 1;
const size_t typeWidthSize = 1 << typeWidth;
const size_t expectedSize =
(storageTypeRange < typeWidthSize) ? storageTypeRange : typeWidthSize;

const auto quantileArraySize = quantiles.size();
if (quantileArraySize != expectedSize) {
return emitError() << "quantiles array size needs to be equal to "
"2^(bit_size(storageType)), expected: "
"2^(bit_size(storageType)), or (storageTypeMax - "
"storageTypeMin + 1) when max and min differ from "
"the type limits; expected: "
<< expectedSize << ", found: " << quantileArraySize;
}

Expand Down
9 changes: 9 additions & 0 deletions mlir/test/Dialect/Quant/parse-quantile-invalid.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,15 @@ func.func @parse() -> !qalias {
return %0 : !qalias
}

// -----
// Illegal quantile array size (per axis type)
// expected-error@+1 {{quantiles array size needs to be equal to 2^(bit_size(storageType)), or (storageTypeMax - storageTypeMin + 1) when max and min differ from the type limits; expected: 256, found: 2}}
!qalias = !quant.quantile<i8:f16:f32:1, {-1.0,1.0}:{-2.0e+2,-0.99872:120}>
func.func @parse() -> !qalias {
%0 = "foo"() : () -> !qalias
return %0 : !qalias
}

// -----
// Unrecognized token: trailing
// expected-error@+1 {{expected '>'}}
Expand Down