Skip to content

Port Ubunu-24 warning fixes to npu/release/18.x #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Port Ubunu-24 warning fixes to npu/release/18.x #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
479b46d
Fix <anonymous> declared here
DariaMityagina Jun 19, 2024
fd68341
Fix Ubuntu24 (#33)
DariaMityagina Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/include/llvm/ADT/FunctionExtras.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ template <typename ReturnT, typename... ParamTs> class UniqueFunctionBase {
void *StoragePtr;
size_t Size;
size_t Alignment;
} OutOfLineStorage;
} OutOfLineStorage = {};
Copy link
Contributor

@andrey-golubev andrey-golubev Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: i'm still not sure what will this do (hopefully, zero-initialize) but whatever. if it silences the things, sure.

I would've done this though:

    struct OutOfLineStorageT {
      void *StoragePtr = nullptr;
      size_t Size = 0;
      size_t Alignment = 0;
    } OutOfLineStorage = {};

Copy link
Contributor

@Maxim-Doronin Maxim-Doronin Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as void* and size_t are primitive types, {} should initialize them with zero, yes

static_assert(
sizeof(OutOfLineStorageT) <= InlineStorageSize,
"Should always use all of the out-of-line storage for inline storage!");
Expand Down
2 changes: 1 addition & 1 deletion llvm/include/llvm/Support/FormatProviders.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ struct format_provider<
private:
public:
static void format(const T &V, llvm::raw_ostream &Stream, StringRef Style) {
HexPrintStyle HS;
HexPrintStyle HS = HexPrintStyle::PrefixUpper;
size_t Digits = 0;
if (consumeHexStyle(Style, HS)) {
Digits = consumeNumHexDigits(Style, HS, 0);
Expand Down