azure ut basic fix #252
Merged
azure ut basic fix #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sun, Xuehao <[email protected]>
Signed-off-by: Sun, Xuehao <[email protected]>
Signed-off-by: Sun, Xuehao <[email protected]>
Contributor
Author
|
coverage decrease test: https://dev.azure.com/lpot-inc/neural-compressor/_build/results?buildId=5741&view=results |
Contributor
|
don't include your name in PR title |
Signed-off-by: Sun, Xuehao <[email protected]>
Signed-off-by: Sun, Xuehao <[email protected]>
chensuyue
approved these changes
Dec 9, 2022
zehao-intel
pushed a commit
that referenced
this pull request
Dec 20, 2022
Signed-off-by: Sun, Xuehao <[email protected]> Signed-off-by: zehao-intel <[email protected]>
yiliu30
pushed a commit
that referenced
this pull request
Oct 27, 2025
In the input, we use zero tokens for padding. After the linear layer, we set the corresponding positions (from the padding) to -inf, so that the softmax outputs values close to epsilon. When using FSDPA optimization, to improve performance, we avoid copying the -inf values to the softmax and instead set them directly to zero. As a result, the softmax output becomes exactly zero (as opposed to a small epsilon value without the FSDP optimization). When computing the dynamic scale for the out_proj, this leads to a division by zero issue. The fix we're implementing is to use max(epsilon, scale) during scale calc. This fix aligns non-CGUID code to act the same as the CGUID flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
fix azure UT Basic artifact error
Description
fix azure UT Basic artifact error:
set condition: succeededOrFailed()
another fix
Expected Behavior & Potential Risk
generate report when coverage failed
How has this PR been tested?
UT-Basic succeed,
generate report when coverage failed
Dependency Change?
no