Skip to content

Integrate new-developed pruning API with old one. #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 119 commits into from
Closed

Integrate new-developed pruning API with old one. #226

wants to merge 119 commits into from

Conversation

@YIYANGCAI
Copy link
Contributor

@YIYANGCAI YIYANGCAI commented Dec 7, 2022

Signed-off-by: YIYANGCAI [email protected]

Type of Change

Merge two pruning APIs to one.
API changed

Description

will be linked to PR#144

WeiweiZhang1 and others added 17 commits December 5, 2022 13:23
@WeiweiZhang1
decouple criterias from pruner
9e900d5 
Signed-off-by: Zhang, Weiwei1 <[email protected]>
@WeiweiZhang1
remove development code
9cd602b 
Signed-off-by: Zhang, Weiwei1 <[email protected]>
@WeiweiZhang1
add docstring, reorg progressive pruner
e7d76ef 
Signed-off-by: Zhang, Weiwei1 <[email protected]>
@WeiweiZhang1
fix typo
847f75a 
Signed-off-by: Zhang, Weiwei1 <[email protected]>
@WeiweiZhang1
add yolov5 example
1868294 
Signed-off-by: Zhang, Weiwei1 <[email protected]>
@WeiweiZhang1
modify docstring and formatting errors, add copyright description
a93ecb5 
Signed-off-by: Zhang, Weiwei1 <[email protected]>
@WeiweiZhang1
rm useless function, bugfix
e4eca40 
Signed-off-by: Zhang, Weiwei1 <[email protected]>
@WeiweiZhang1
bugfixs2
c698b02 
Signed-off-by: Zhang, Weiwei1 <[email protected]>
@WeiweiZhang1
fix typos
c4568d8 
Signed-off-by: Zhang, Weiwei1 <[email protected]>
@WeiweiZhang1
add dictionary
1372b78 
Signed-off-by: Zhang, Weiwei1 <[email protected]>
@WeiweiZhang1
fix typos about criterion
12a27e6 
Signed-off-by: Zhang, Weiwei1 <[email protected]>
@WeiweiZhang1
modify pruning config, add progressive test-case
c9970ff 
Signed-off-by: Zhang, Weiwei1 <[email protected]>
@YIYANGCAI
Merged new-developed pruning API to old one.
08c6b8d 
Signed-off-by: YIYANGCAI <[email protected]>
test
73edbef
adjust pruning location
08b9924
adjust pruning location
110111f
fix typo
77095d5 
Signed-off-by: wenhuach <dd>
@ftian1
Copy link
Contributor

ftian1 commented Dec 7, 2022

this title is not suitable as a commit message. you don't need mention merge things. you can mentioned new pruning algo or something else

@YIYANGCAI YIYANGCAI changed the title Merged new-developed pruning API to old one. Integrate new-developed pruning API with old one. Dec 7, 2022
ftian1
ftian1 reviewed Dec 7, 2022
View reviewed changes
...les/pytorch/nlp/huggingface_models/question-answering/pruning/pytorch_pruner/eager/README.md Outdated
end_step=int(total_iterations)) ##iterative
else:
pruner.update_items_for_all_pruners(start_step=total_iterations+1, end_step=total_iterations+1) ## remove the pruner
pruner.update_items_for_all_pruners(start_step=total_iterations + 1,
Copy link
Contributor

@ftian1 ftian1 Dec 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall this func get exposed to external user? is it possible to hide this part?

Copy link
Contributor

@wenhuach21 wenhuach21 Dec 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some configs like start_step and end_step are affected by the training hyperparameters, which users should usually tune. This function eases users to change these configs. I suggest keeping it, but of course, removing it does not affect the functionality

ftian1
ftian1 reviewed Dec 7, 2022
View reviewed changes
ftian1
ftian1 reviewed Dec 7, 2022
View reviewed changes
ftian1
ftian1 reviewed Dec 7, 2022
View reviewed changes
YIYANGCAI and others added 3 commits December 7, 2022 17:29
@YIYANGCAI @WeiweiZhang1
Merged new-developed pruning API to old one.
aa321cb 
Signed-off-by: YIYANGCAI <[email protected]>
Signed-off-by: Zhang, Weiwei1 <[email protected]>
@WeiweiZhang1
test
5e5caa0 
Signed-off-by: Zhang, Weiwei1 <[email protected]>
@WeiweiZhang1
adjust pruning location
ed4276d 
Signed-off-by: Zhang, Weiwei1 <[email protected]>
@chensuyue
Copy link
Contributor

chensuyue commented Dec 9, 2022

Do we need this PR: #144

@ftian1
Copy link
Contributor

ftian1 commented Dec 9, 2022

@wenhuach21 there is conflict to be solved. and I saw the neural_compressor/conf/config.py is modified? this will impact backward compatibility. you should only modify neural_compressor/config.py which is newly introduce for inc 2.0.

@ftian1
Copy link
Contributor

ftian1 commented Dec 9, 2022

as I mentioned before, we have 3 sets of API due to historical reason.

  1. API in top name space of v1.x, which should be totally removed
  2. experimental API, which is yaml based and should keep unchanged for backward compatibility. it used yaml file and neural_compressor/conf/.
  3. API 2.0, which discard yaml. so your changes shouldn't touch neural_compressor/conf/ folder at all. and all examples should be without yaml and is pure python code.

YIYANGCAI and others added 10 commits December 9, 2022 18:46
@chensuyue chensuyue mentioned this pull request Dec 9, 2022
Closed
@yintong-lu
pruning README v2
cbf24e5 
Signed-off-by: Lu, Yintong <[email protected]>
@wenhuach21 wenhuach21 closed this Dec 12, 2022
VincyZhang pushed a commit that referenced this pull request Feb 12, 2023
@Eason9393
add patterns tuning and graph tuning (#226)
f70394c
@chensuyue chensuyue deleted the cyy/pruning-api-merge branch June 15, 2023 05:50
yiliu30 pushed a commit that referenced this pull request Apr 30, 2025
@linoybu
[SW-227504] disabled test (#226)
6527eb5
xin3he pushed a commit that referenced this pull request Jul 15, 2025
@linoybu @xinhe3
[SW-227504] disabled test (#226)
c2f9b67
XuehaoSun pushed a commit that referenced this pull request Jul 19, 2025
@linoybu @XuehaoSun
[SW-227504] disabled test (#226)
fbba1a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wenhuach21 wenhuach21 wenhuach21 left review comments

@ftian1 ftian1 ftian1 approved these changes

Assignees

No one assigned

Labels

new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@YIYANGCAI @ftian1 @chensuyue @wenhuach21 @WeiweiZhang1 @yintong-lu