Skip to content

Conversation

@yiliu30
Copy link
Contributor

@yiliu30 yiliu30 commented Jan 28, 2024

Type of Change

API changed or not: None

Description

# Recommend usage
from neural_compressor.common import logger
logger.info("Log info: %s", log_str)

from neural_compressor.common import Logger
from neural_compressor.common.utils import Logger
logger = Logger().get_logger()
logger.info("Log info: %s", log_str)

How has this PR been tested?

Pre-CI

Dependency Change?

None

Signed-off-by: yiliu30 <[email protected]>
Signed-off-by: yiliu30 <[email protected]>
@yiliu30 yiliu30 added the INC3.X label Jan 28, 2024
Signed-off-by: yiliu30 <[email protected]>
Signed-off-by: yiliu30 <[email protected]>
Signed-off-by: yiliu30 <[email protected]>
@yiliu30
Copy link
Contributor Author

yiliu30 commented Jan 29, 2024

Hi @chensuyue, the UT coverage report shows that all PR and base files have the same branch and Miss, yet the coverage has fallen nonetheless. Am I missing something?

image

@chensuyue
Copy link
Contributor

Hi @chensuyue, the UT coverage report shows that all PR and base files have the same branch and Miss, yet the coverage has fallen nonetheless. Am I missing something?

image

Coverage count should have some issues, I will check.

chensuyue and others added 2 commits January 29, 2024 11:16
Signed-off-by: chensuyue <[email protected]>
Signed-off-by: yiliu30 <[email protected]>
@chensuyue
Copy link
Contributor

chensuyue commented Jan 29, 2024

image
image
In this case, the covered line/branch and overall item decrease the same number, so the ratio decreased, but the missed line didn't change. In most of other cases, new PR will increase the overall code lines and branch.

@yiliu30
Copy link
Contributor Author

yiliu30 commented Jan 29, 2024

image image In this case, the covered line/branch and overall item decrease the same number, so the ratio decreased, but the missed line didn't change. In most of other cases, new PR will increase the overall code lines and branch.

Nice catch, thanks.

@chensuyue chensuyue merged commit f50baf2 into master Jan 29, 2024
@chensuyue chensuyue deleted the ly/fix_log branch January 29, 2024 04:49
chensuyue added a commit that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants