fix: Added active_boot_type for alter_host #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the active_boot_type parameter in the alter_host method by conditionally including it in the parameters dictionary when provided. This enhancement allows users to specify the active boot type when altering host configurations.
- Added conditional logic to include
active_boot_typeparameter when not None - Uses
.valueattribute indicatingactive_boot_typeis likely an enum
|
We don't publish DEVs .whl. |
1 similar comment
|
We don't publish DEVs .whl. |
mchromin
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a minor enhancement to the
alter_hostmethod inmfd_osd_control.py. The change adds support for setting theactive_boot_typeparameter when it is provided.mfd_osd_control/mfd_osd_control.py: Added logic to include theactive_boot_typeparameter in theparamsdictionary if it is notNone. ([mfd_osd_control/mfd_osd_control.pyR244-R245](https://github.com/intel/mfd-osd-control/pull/3/files#diff-31b78073458b27c4107b06445243f6d4f7eb943a0c65bfd19bbeaea2d1158b62R244-R245))