Skip to content

Conversation

adrianlasota
Copy link

This pull request makes a minor update to how MAC addresses are handled when filtering interface information. Specifically, it ensures that the MAC address is always converted to lowercase before being used. This helps maintain consistency and avoid potential mismatches due to case sensitivity.

  • Consistently converts the mac_address field to lowercase in the _get_filtered_interface_info_by_topology function in mfd_host/base.py.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for MAC address handling in network interface creation by ensuring MAC addresses are consistently converted to lowercase before being used. This prevents potential mismatches due to case sensitivity when filtering interface information.

  • Converts MAC address to lowercase in the _get_filtered_interface_info_by_topology function
  • Maintains consistency in MAC address formatting across the system

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mfd-intel-bot
Copy link

We don't publish DEVs .whl.
To build .whl, run 'pip install git+https://github.com/intel/mfd-host@mac_address'

1 similar comment
@mfd-intel-bot
Copy link

We don't publish DEVs .whl.
To build .whl, run 'pip install git+https://github.com/intel/mfd-host@mac_address'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants