Fix a ULT fail issue when driver dynamically links gmmlib. #280
Conversation
| Clear(); | ||
| } | ||
|
|
||
| void Clear() |
There was a problem hiding this comment.
Folks, I strongly suggest to remove constructor and Clear() entirely, You have class with all public members. C++11 already has a way to reset a structure to default value-initialization which is: m_drvSyms = {}.
There was a problem hiding this comment.
Thank you for catching this, "m_drvSyms = {}" is much better than a Clear function.
| { | ||
| auto p = (const void * const *)this; | ||
| for (auto i = 0; i < sizeof(this) / sizeof(const void *); i++) | ||
| for (auto i = 0; i < sizeof(*this) / sizeof(const void *); i++) |
There was a problem hiding this comment.
Folks, please, remove this and check pointers directly. This is simply a freak over complex implementation of very simple thing: check 5 pointers that they are not NULL. You don't need any loop here!!
There was a problem hiding this comment.
Yes, checking 5 pointers is simpler and easier to understand than previous code.
|
It has been combined with PR#270. close it. |
3 participants
Fix a ULT fail issue when driver dynamically links gmmlib.