[upstream] switch to dynamic gmm lib #274
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang, Ning <[email protected]>
dvrogozh
suggested changes
Aug 14, 2018
|
|
||
| if(LIBGMM_FOUND) | ||
| include_directories(BEFORE ${LIBGMM_INCLUDE_DIRS}) | ||
| link_directories(${LIBGMM_LIBRARY_DIRS}) |
There was a problem hiding this comment.
You can't call link_directories() after add_library(): it will not take effect. You can see this if you will configure and install gmmlib to the custom location. I get this error with your PR:
/usr/bin/ld: cannot find -ligdgmm
I have fixed this in my PR: #270. Please, take a look
| endif() | ||
|
|
||
| include(${MEDIA_DRIVER_CMAKE}/ext/media_feature_include_ext.cmake OPTIONAL) | ||
| target_compile_definitions(${LIB_NAME} PUBLIC GMM_LIB_DLL) |
There was a problem hiding this comment.
This is not needed because igdgmm.pc have this:
https://github.com/intel/gmmlib/blob/4f787cc7c47b5b79ff20c264852f1213f21e898d/Source/GmmLib/igdgmm.pc.in#L9
| output_dri_init(ctx); | ||
| #endif | ||
|
|
||
| void *gmm_handle = dlopen(GMM_UMD_DLL, RTLD_NOW); |
There was a problem hiding this comment.
You link against igdgmm, you don't need to dlopen() it and search for symbols. You can see here how this should actually be done: 700ac49#diff-142d67e662b77af7cb7deda2856b8118R1401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yang, Ning [email protected]