-
Notifications
You must be signed in to change notification settings - Fork 795
[SYCL] Add sycl wrappers for fp conversions. #9431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Add sycl wrappers for fp conversions. #9431
Conversation
Signed-off-by: jinge90 <[email protected]>
…or_bf16_conversions
…or_bf16_conversions
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
…or_bf16_conversions
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
…or_bf16_conversions
…_bf16_conversions
|
Hi, @zhimingwang36 |
|
I don't think I have enough expertise to review this... |
|
Hi, @akolesov-intel |
akolesov-nv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable. Thank you for taking care!
tangjj11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: jinge90 <[email protected]>
…or_bf16_conversions
Signed-off-by: jinge90 <[email protected]>
steffenlarsen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Hi, @intel/llvm-gatekeepers |
This PR adds C++ wrappers in intel math header for type conversion functions provided in SYCL libdevice. The function names align with CUDA correspondence but we don't use "__" prefix in function name. For example, CUDA __double2float_ru maps to sycl::ext::intel::math::double2float_ru. --------- Signed-off-by: jinge90 <[email protected]>
This PR adds C++ wrappers in intel math header for type conversion functions provided in SYCL libdevice.
The function names align with CUDA correspondence but we don't use "__" prefix in function name.
For example, CUDA __double2float_ru maps to sycl::ext::intel::math::double2float_ru.