-
Notifications
You must be signed in to change notification settings - Fork 791
[SYCL] No L0_Loader in product. #9361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] No L0_Loader in product. #9361
Conversation
Was temporarily added to enable win GHA testing in December, but should no longer be necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an overlap with my #9166
It also requires Windows CI update (to locate L0 loader)
|
@smaslov-intel - In 9166 are you expecting the L0 Loader to be provided by the product itself? We definitely have to remove it from intel/llvm. Also, will 9166 fix the interop tests on Windows? I noticed the L0 interop tests aren't being run by our GitHubActions on Win. |
No, the L0 loader is provided by the users (Windows CI in this case)
Yes, the intent is to have L0 interop running on Windows. I see they were failing until I provided the L0 loader location, so I assume that is the case. |
|
@cperkinsintel : in the merged #9166 I have removed install of L0 loader. Can you update this PR to additionally remove include files? |
…/cperkinsintel/llvm into cperkins-no-l0_loader-in-product
|
@smaslov-intel - my apologies for overlooking this. The tests in question don't include ze_api.h, so there shouldn't be a problem there, just the removal of the flag is enough. Or did you mean something else? |
All is good, that's what I was asking. |
Was temporarily added to enable win GHA testing in December, but should no longer be necessary.