Skip to content

Conversation

@cperkinsintel
Copy link
Contributor

Was temporarily added to enable win GHA testing in December, but should no longer be necessary.

Was temporarily added to enable win GHA testing in December, but should no longer be necessary.
@cperkinsintel cperkinsintel temporarily deployed to aws May 8, 2023 23:12 — with GitHub Actions Inactive
@cperkinsintel cperkinsintel temporarily deployed to aws May 9, 2023 01:12 — with GitHub Actions Inactive
@cperkinsintel cperkinsintel temporarily deployed to aws May 9, 2023 20:34 — with GitHub Actions Inactive
@cperkinsintel cperkinsintel temporarily deployed to aws May 9, 2023 23:17 — with GitHub Actions Inactive
@cperkinsintel cperkinsintel marked this pull request as ready for review May 10, 2023 03:33
@cperkinsintel cperkinsintel requested review from a team as code owners May 10, 2023 03:33
@cperkinsintel cperkinsintel temporarily deployed to aws May 10, 2023 03:38 — with GitHub Actions Inactive
@cperkinsintel cperkinsintel temporarily deployed to aws May 10, 2023 04:52 — with GitHub Actions Inactive
Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an overlap with my #9166
It also requires Windows CI update (to locate L0 loader)

@cperkinsintel
Copy link
Contributor Author

@smaslov-intel - In 9166 are you expecting the L0 Loader to be provided by the product itself? We definitely have to remove it from intel/llvm.

Also, will 9166 fix the interop tests on Windows? I noticed the L0 interop tests aren't being run by our GitHubActions on Win.

@smaslov-intel
Copy link
Contributor

@smaslov-intel - In 9166 are you expecting the L0 Loader to be provided by the product itself? We definitely have to remove it from intel/llvm.

No, the L0 loader is provided by the users (Windows CI in this case)

Also, will 9166 fix the interop tests on Windows? I noticed the L0 interop tests aren't being run by our GitHubActions on Win.

Yes, the intent is to have L0 interop running on Windows. I see they were failing until I provided the L0 loader location, so I assume that is the case.

@smaslov-intel
Copy link
Contributor

@cperkinsintel : in the merged #9166 I have removed install of L0 loader. Can you update this PR to additionally remove include files?

@cperkinsintel cperkinsintel temporarily deployed to aws May 17, 2023 18:41 — with GitHub Actions Inactive
@cperkinsintel cperkinsintel temporarily deployed to aws May 17, 2023 19:16 — with GitHub Actions Inactive
@cperkinsintel
Copy link
Contributor Author

@smaslov-intel - my apologies for overlooking this. The tests in question don't include ze_api.h, so there shouldn't be a problem there, just the removal of the flag is enough. Or did you mean something else?

@smaslov-intel
Copy link
Contributor

@smaslov-intel - my apologies for overlooking this. The tests in question don't include ze_api.h, so there shouldn't be a problem there, just the removal of the flag is enough. Or did you mean something else?

All is good, that's what I was asking.

@cperkinsintel cperkinsintel temporarily deployed to aws May 17, 2023 22:04 — with GitHub Actions Inactive
@cperkinsintel cperkinsintel temporarily deployed to aws May 17, 2023 22:36 — with GitHub Actions Inactive
@againull againull merged commit 6581bc0 into intel:sycl May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants