[SYCL] Fix a race condition in queue wait unit test #8495
Conversation
The test relies on the fact that the tasks submitted to the queue haven't been enqueued before the call to queue::wait. Guarantee that by manually blocking/unblocking their enqueue with a dependency node instead of relying on a host task.
sergey-semenov
changed the title
|
|
|
@dm-vodopyanov @intel/llvm-reviewers-runtime Could you please take a look? |
There was a problem hiding this comment.
I am okay with it as-is, to get things working as intended.
That said I worry that this is maybe a little too deep in implementation-details. Would it have been possible to somehow create an unfinished event, use it as a dependency, then mark it finished when we need it? It may be as implementation-specific as this.
|
@steffenlarsen The problem here is that we need to create a situation where some commands both haven't been enqueued and are unblocked. In any user application this will only occur when there are blocked commands. And any of the usual ways to block commands (host tasks & host accessors) would attempt to enqueue their users after they're unblocked. I don't see how an unfinished event would help here. I guess one alternative solution would be to construct the graph directly to avoid trying to enqueue the tasks in the first place, but that's even more implementation-specific. |
4 participants
The test relies on the fact that the tasks submitted to the queue haven't been enqueued before the call to queue::wait. Guarantee that by manually blocking/unblocking their dependency node instead of relying on a host task.