Skip to content

[SYCL] Add double to bfloat16 conversion in imf libdevice #8403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 2, 2023
Merged

[SYCL] Add double to bfloat16 conversion in imf libdevice #8403

merged 7 commits into from
Mar 2, 2023

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Feb 20, 2023 •
edited
Loading

Add double to bfloat16 utils to imf libdevice, the corresponding test is in: intel/llvm-test-suite#1608

@jinge90 jinge90 requested review from a team as code owners February 20, 2023 02:18
@jinge90 jinge90 requested a review from againull February 20, 2023 02:18
@jinge90 jinge90 marked this pull request as draft February 20, 2023 02:18
@jinge90 jinge90 temporarily deployed to aws February 21, 2023 05:26 — with GitHub Actions Inactive
@jinge90 jinge90 mentioned this pull request Feb 22, 2023
Open
@jinge90 jinge90 marked this pull request as ready for review February 23, 2023 03:00
@jinge90 jinge90 temporarily deployed to aws February 23, 2023 03:10 — with GitHub Actions Inactive
@jinge90
Copy link
Contributor Author

jinge90 commented Feb 23, 2023

Hi, @xtian-github @zettai-reido @akolesov-intel
This PR aims to add double-to-bfloat16 conversion utils, could you help review it?
Thanks very much.

@jinge90
Copy link
Contributor Author

jinge90 commented Feb 23, 2023

/verify with intel/llvm-test-suite#1608

@jinge90 jinge90 temporarily deployed to aws February 23, 2023 03:52 — with GitHub Actions Inactive
@jinge90
Copy link
Contributor Author

jinge90 commented Feb 25, 2023

Hi, @xtian-github @zettai-reido @akolesov-intel
Kind ping~

zettai-reido
zettai-reido reviewed Feb 25, 2023
View reviewed changes
Copy link

@zettai-reido zettai-reido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct.
But I would like to avoid type punning through union as it was problematic in the past
with exactly IGC compiler we targeting.

Also,
but it is a matter of code style and might not be accepted in this header,
long constants read better annotated with '.
0x3ff0'0000'0000'0000

@jinge90 jinge90 temporarily deployed to aws March 1, 2023 04:55 — with GitHub Actions Inactive
zettai-reido
zettai-reido approved these changes Mar 1, 2023
View reviewed changes
Copy link

@zettai-reido zettai-reido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for addressing comments.

@jinge90
Copy link
Contributor Author

jinge90 commented Mar 2, 2023

Hi, @intel/dpcpp-tools-reviewers
Could you take a loot at this PR?
Thanks very much.

AlexeySachkov
AlexeySachkov approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sycl-post-link part LGTM

@jinge90 jinge90 temporarily deployed to aws March 2, 2023 10:44 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to aws March 2, 2023 11:27 — with GitHub Actions Inactive
@AlexeySachkov
Copy link
Contributor

Failing HIP test was disabled in intel/llvm-test-suite#1625

  ********************
  Failed Tests (1):
    SYCL :: SubGroup/shuffle_fp64.cpp

Seems to be unrelated. Could be caused by recent test changes done in intel/llvm-test-suite#1618. Tagging @maksimsab for awareness

@AlexeySachkov AlexeySachkov merged commit 4405f13 into intel:sycl Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeySachkov AlexeySachkov AlexeySachkov approved these changes

@akolesov-nv akolesov-nv akolesov-nv approved these changes

@xtian-github xtian-github xtian-github approved these changes

@againull againull againull approved these changes

@zettai-reido zettai-reido zettai-reido approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jinge90 @AlexeySachkov @akolesov-nv @xtian-github @againull @zettai-reido @bader