Skip to content

Fix fp-accuracy build problems and minor cosmetic issues #8200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Fix fp-accuracy build problems and minor cosmetic issues #8200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/docs/LangRef.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23134,7 +23134,7 @@ intrinsic has any callsite attributes begining with "fpbuiltin-" that the code
performing the transformation does not recognize.

Unless otherwise specified using callsite attributes, the fpbuiltin intrinsics
do not set ``errno`` or and are not guaranteed to maintain correct
do not set ``errno`` and are not guaranteed to maintain correct
floating-point exception state.

All fpbuiltin intrinsics are overloaded intrinsics which may operate on any
Expand Down
4 changes: 2 additions & 2 deletions llvm/include/llvm/Analysis/TargetLibraryInfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class Function;
class Module;
class Triple;

/// Describes a possible implementation of a floating point builtin operation
/// Describes a possible implementation of a floating point builtin operation.
struct AltMathDesc {
Intrinsic::ID IntrinID;
Type::TypeID BaseFPType;
Expand Down Expand Up @@ -79,7 +79,7 @@ class TargetLibraryInfoImpl {
}

/// Alternate math library functions - sorted by intrinsic ID, then type,
/// then vector size, then accuracy
/// then vector size, then accuracy
std::vector<AltMathDesc> AltMathFuncDescs;

/// Vectorization descriptors - sorted by ScalarFnName.
Expand Down
4 changes: 2 additions & 2 deletions llvm/lib/CodeGen/FPBuiltinFnSelection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ static bool selectFnForFPBuiltinCalls(const TargetLibraryInfo &TLI,
dbgs() << BuiltinCall.getRequiredAccuracy().value() << "\n";
});

StringSet RecognizedAttrs = {FPBuiltinIntrinsic::FPBUILTIN_MAX_ERROR};
StringSet<> RecognizedAttrs = {FPBuiltinIntrinsic::FPBUILTIN_MAX_ERROR};
if (BuiltinCall.hasUnrecognizedFPAttrs(RecognizedAttrs)) {
report_fatal_error(
Twine(BuiltinCall.getCalledFunction()->getName()) +
Expand Down Expand Up @@ -142,7 +142,7 @@ class FPBuiltinFnSelectionLegacyPass : public FunctionPass {
return runImpl(*TLI, F);
}

void getAnalysisUsage(AnalysisUsage &AU) const {
void getAnalysisUsage(AnalysisUsage &AU) const override {
AU.setPreservesCFG();
AU.addRequired<TargetLibraryInfoWrapperPass>();
AU.addPreserved<TargetLibraryInfoWrapperPass>();
Expand Down