[SYCL] Add ext_oneapi_unified_runtime SYCL backend #7765
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey V Maslov <[email protected]>
* Fix issues on level_zero build based on FetchContent * Remove installation of level_zero loader into the toolchain * Fix dependencies At this point there are undefined references at unified runtime link as .so library. WIP.
* Keep global CMAKE_INCLUDE_CURRENT_DIR=ON like llvm sets it. Instead turning it OFF for level_zero build * adding ze_loader to unified runtime deps
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Now build is successful
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Co-authored-by: Steffen Larsen <[email protected]>
Co-authored-by: Steffen Larsen <[email protected]>
…ero.cpp Co-authored-by: Steffen Larsen <[email protected]>
…ero.hpp Co-authored-by: Steffen Larsen <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
|
@againull : @sergey-semenov : please review fac63e9 |
againull
reviewed
Dec 15, 2022
Comment on lines
-129
to
+130
| if (!Platform.get_devices(info::device_type::all).empty()) | ||
| Platforms.push_back(Platform); | ||
| // if (!Platform.get_devices(info::device_type::all).empty()) | ||
| Platforms.push_back(Platform); |
There was a problem hiding this comment.
As far as I understand unified runtime doesn't expose any devices yet and probably that's why this change was made for testing. Should we uncomment it for now? Or do we actually want to include platforms without devices?
There was a problem hiding this comment.
That's right, no devices. And I couldn't find in SYCL spec that platforms without devices should not be exposed.
|
Just minor comments, other than that fac63e9 looks good to me. |
smaslov-intel
commented
Dec 15, 2022
|
moved to #7816 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new backend to SYCL: ext_oneapi_unified_runtime
E2E test: intel/llvm-test-suite#1450
NOTE: only review changes since fac63e9
The backend is being implemented by the plugin in #7521
Plugin is still gated by #7730