[SYCL-MLIR] Improve warning and debug messages #7570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victor-eds
commented
Nov 29, 2022
whitneywhtsang
approved these changes
Nov 29, 2022
etiotto
reviewed
Nov 29, 2022
etiotto
left a comment
etiotto
left a comment
There was a problem hiding this comment.
Suggest using LLVM_DEBUG macro to wrap debug code (even is an assertion will be emitted).
etiotto
reviewed
Nov 29, 2022
etiotto
left a comment
etiotto
left a comment
There was a problem hiding this comment.
Suggest using LLVM_DEBUG macro to wrap debug code (even is an assertion will be emitted).
Use mlirclang::warning or llvm::dbgs when suitable. Signed-off-by: Victor Perez <[email protected]>
victor-eds
force-pushed
the
change-warnings
branch
from
988a211 to
91af938
Compare
etiotto
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use mlirclang::warning or llvm::dbgs when suitable.
Signed-off-by: Victor Perez [email protected]