Skip to content

[SYCL] Fix piEnqueueEventsWaitWithBarrier for in-order queues #7475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2022
Merged

[SYCL] Fix piEnqueueEventsWaitWithBarrier for in-order queues #7475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions sycl/plugins/level_zero/pi_level_zero.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6661,7 +6661,11 @@ pi_result piEnqueueEventsWaitWithBarrier(pi_queue Queue,
// We use the same approach if
// SYCL_PI_LEVEL_ZERO_USE_MULTIPLE_COMMANDLIST_BARRIERS is not set to a
// positive value.
if (NumEventsInWaitList || !UseMultipleCmdlistBarriers) {
// We use the same approach if we have in-order queue because every command
// depends on previous one, so we don't need to insert barrier to multiple
// command lists.
if (NumEventsInWaitList || !UseMultipleCmdlistBarriers ||
Queue->isInOrderQueue()) {
// Retain the events as they will be owned by the result event.
_pi_ze_event_list_t TmpWaitList;
if (auto Res = TmpWaitList.createAndRetainPiZeEventList(
Expand All @@ -6684,7 +6688,9 @@ pi_result piEnqueueEventsWaitWithBarrier(pi_queue Queue,
if (auto Res = Queue->executeCommandList(CmdList, false, OkToBatch))
return Res;

if (UseMultipleCmdlistBarriers) {
// Because of the dependency between commands in the in-order queue we don't
// need to keep track of any active barriers if we have in-order queue.
if (UseMultipleCmdlistBarriers && !Queue->isInOrderQueue()) {
// Retain and save the resulting event for future commands.
(*Event)->RefCount.increment();
Queue->ActiveBarriers.push_back(*Event);
Expand Down