Skip to content

[SYCL][NFC] Properly use emplace_back in sycl-post-link #7469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AlexeySachkov
Copy link
Contributor

We used to create a temporary object and pass it to emplace_back. Refactored code so we pass arguments to constructor directly without creating a temporary object.

We used to create a temporary object and pass it to `emplace_back`.
Refactored code so we pass arguments to constructor directly without
creating a temporary object.
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@pvchupin pvchupin merged commit 764e2ba into intel:sycl Nov 21, 2022
@AlexeySachkov AlexeySachkov deleted the private/asachkov/fix-emplace-back-usages-in-sycl-post-link branch March 29, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants