Skip to content

[SYCL] Update ABI check for Ubuntu 22 differences #7446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2022
Merged

[SYCL] Update ABI check for Ubuntu 22 differences #7446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions sycl/test/tools/abi_check_positive_dump.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
__libc_csu_fini
__libc_csu_init
_start
_Z3foov
main
7 changes: 7 additions & 0 deletions sycl/tools/abi_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,13 @@ def parse_readobj_output(output):
# is used. Ignore it for the purpose of the library ABI check.
ignore_symbols = ["_dl_relocate_static_pie"]

# Starting from glibc 2.34 these symbols are not present anymore in the binary
# Ignoring these in case older glibc is used.
# Note that Ubuntu 20 has glibc 2.31 and Ubuntu 22 has glibc 2.35
# See: https://github.com/bminor/glibc/commit/035c012e32c11e84d64905efaf55e74f704d3668
ignore_symbols += ["__libc_csu_fini",
"__libc_csu_init"]

# In some scenarios MSVC and clang-cl exhibit differences in regards to the exported symbols they generate.
# Some of them happen in the SYCL RT library and we think clang-cl's behavior is more reasonable.
#
Expand Down